Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/keyboard fixes #13

Merged
merged 12 commits into from
Oct 20, 2017
Merged

Feature/keyboard fixes #13

merged 12 commits into from
Oct 20, 2017

Conversation

bdudar
Copy link

@bdudar bdudar commented Oct 19, 2017

No description provided.

pgs-dkanak and others added 12 commits April 3, 2017 14:40
placeholder text in settings works
corrected access to button actions
scaleAspectFit for button images
organised settings order
settings made all public
…type, appearance, return type key, return key auto-enabled, right action by return key), trimming and preventing empty text in demo
}
set {
toolbarContentView.inputText = newValue
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of explicit dividing getters and setters here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You tell me ;) Commit: d007b8e

@pgs-dkanak pgs-dkanak merged commit 5945df6 into develop Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants